Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.11] signal-desktop: 7.4.0 -> 7.5.1; signal-desktop-beta: 7.3.0-beta.1 -> 7.6.0-beta.3 #305793

Merged
merged 4 commits into from
Apr 25, 2024

Conversation

teutat3s
Copy link
Member

Description of changes

Manual backport of #305339.

https://github.com/signalapp/Signal-Desktop/releases/tag/v7.5.0
https://github.com/signalapp/Signal-Desktop/releases/tag/v7.5.1

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@teutat3s
Copy link
Member Author

#297977 and #300140 were not backported to release-23.11. That's why the cherry-pick CI check fails.

@teutat3s
Copy link
Member Author

See #301844 (comment) for the failing test.

@risicle
Copy link
Contributor

risicle commented Apr 24, 2024

Normally when we're doing backports that jump multiple versions we cherry-pick each bump commit separately in series. This way we end up with a much clearer result.

@teutat3s teutat3s force-pushed the backport-305339-to-release-23.11 branch from 748554d to 24770d8 Compare April 24, 2024 14:47
@drupol drupol merged commit fb65d01 into NixOS:release-23.11 Apr 25, 2024
22 checks passed
@teutat3s teutat3s deleted the backport-305339-to-release-23.11 branch April 25, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants